[Concurrency] Fix nonisolated(nonsending) interaction with #isolation #82793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
requested review from
hborla,
jckarter,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
DougGregor
approved these changes
Jul 4, 2025
test/Concurrency/Runtime/isolated_macro_in_nonisolated_nonsending_func.swift
Show resolved
Hide resolved
|
Moved the check and added a SIL test, thanks for review @DougGregor 👍 |
ktoso
force-pushed
the
wip-correct-isolated-handling-with-caller-isolation
branch
from
a6b4b5b to
b1ca06d
Compare
|
@swift-ci please smoke test |
ktoso
added
the
concurrency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was noticed early on, but we never fixed it.
This makes
#isolationactually find the isolated parameter thatnonisolated(nonsending)implicitly adds to functions.Resolves rdar://155003540